Skip to content

chore: update Kex-Algorithms#9561

Merged
jannfis merged 2 commits intoargoproj:masterfrom
34fathombelow:update-kex-algo
Jun 5, 2022
Merged

chore: update Kex-Algorithms#9561
jannfis merged 2 commits intoargoproj:masterfrom
34fathombelow:update-kex-algo

Conversation

@34fathombelow
Copy link
Copy Markdown
Member

Signed-off-by: douhunt douhunt@protonmail.com

Part 1 of 3 to upgrade base image to Ubuntu:22.04
This must be merged before #9551 and cherry-picked into 2.4

Upgraded golang.org/x/crypto libraries to support diffie-hellman-group14-sha256. I also removed two Kex-Algorithms which should no longer be used for security reasons. This may cause some breakage for a very very small group of users. I would also recommend removing diffie-hellman-group14-sha1 in the very near future (v2.5) and give users plenty of warning.
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants